[patch] always treat "simple obcopy of an executable" test as XFAIL on cygwin
Dave Korn
dave.korn.cygwin@googlemail.com
Fri Jun 26 05:30:00 GMT 2009
Christopher Faylor wrote:
> On Thu, Jun 25, 2009 at 06:17:09PM +0100, Dave Korn wrote:
>> Christopher Faylor wrote:
>>> Just checked this in after checking with Dave Korn that it made sense.
>> Argh. Except that when I got round to testing it natively, it has a side
>> effect:
>
> I carefully inspected that file, noticed the similar mingw test, made
> the wrong decision, and then tested the wrong set of files.
:-/ I carefully inspected your patch, saw that it was correctly setting up
an xfail for cygwin among a whole bunch of other xfails, and completely forgot
to check that it was going in the right place! It reminded me that when
dealing with a patch generated without -p I should always apply it and read
the resulting file instead of just trying to inspect the patch on its own.
> I moved the test to copy_executable.
All fixed now. Thanks!
cheers,
DaveK
More information about the Binutils
mailing list