[PATCH] Fix readelf -sI (or -a)

John Reiser jreiser@BitWagon.com
Fri Jun 12 12:51:00 GMT 2009


> --- binutils/readelf.c.jj	2009-05-28 19:35:03.000000000 +0200
> +++ binutils/readelf.c	2009-06-10 19:57:20.000000000 +0200

> @@ -7270,13 +7280,20 @@ process_symbol_table (FILE * file)

> +	  free (gnubuckets);
> +	  if (do_using_dynamic)
> +	    return 0;
> +	  gnubuckets = NULL;

It would be safer to set gnubuckets to NULL immediately after free()ing.
Allowing 'return' between "free (gnubuckets);" and "gnubuckets = NULL;"
allows bugs to propagate, and possibly making future maintenance more costly.

-- 



More information about the Binutils mailing list