[PATCH] PR977: Weak symbols on win32 - take 3.

Danny Smith dansmister@gmail.com
Mon Jun 8 03:25:00 GMT 2009


I replied to Dave but failed to cc list.  For the record:

On Sat, May 30, 2009 at 4:28 AM, Dave
Korn<dave.korn.cygwin@googlemail.com> wrote:
>
> gas/ChangeLog:
>
>        * config/tc-i386.c (md_estimate_size_before_relax):  Don't relax
>        branches to weak symbols.
>        (md_apply_fix):  Don't convert fixes against weak symbols to
>        section-relative offsets, but save addend for later reloc emission.
>        (tc_gen_reloc):  When emitting reloc against weak symbol, adjust
>        addend to pre-compensate for bfd_install_relocation.
>
>
>  Is this OK by _everyone_ concerned?

Sorry for not replying sooner. This patch looks good to me and causes
no problems with weak externals in my tests.

Thanks for fixing this.

Danny
>
>    cheers,
>      DaveK
> --



More information about the Binutils mailing list