Problem with gas test on cygwin...

[Dave Korn]

Dave Korn wrote:
> Christian Joensson wrote:
>> Hi guys.
>>
>> Windows XP Pro/SP3 cygwin Intel Core2 Duo T9600@2.80GHz system with packages:
>>
>> binutils             (local build)  2.19.51.20090531 (+D Korn's gas weak patch)

  Still fails with my weak patch reverted.  Which makes sense; it shouldn't be
affecting these strongly-defined references in any way.

>> ../as-new  --32  -o dump.o
>> /usr/local/src/trunk/src/gas/testsuite/gas/i386/jump.s
>> Executing on host: sh -c {../as-new  --32  -o dump.o
>> /usr/local/src/trunk/src/gas/testsuite/gas/i386/jump.s 2>&1}
>> /dev/null gas.out (timeout = 300)
>> spawn [open ...]^M
>> /usr/local/src/trunk/objdir-binutils/gas/testsuite/../../binutils/objdump
>>  -drw dump.o
>> Executing on host: sh -c
>> {/usr/local/src/trunk/objdir-binutils/gas/testsuite/../../binutils/objdump
>>  -drw dump.o >dump.out 2>gas.stderr}  /dev/null  (timeout = 300)
>> spawn [open ...]^M
>> regexp_diff match failure
>> regexp "^[      ]*[a-f0-9]+:    eb 00                   jmp    0x7b$"
>> line   "  79:   eb 00                   jmp    7b <.text+0x7b>"
>> regexp_diff match failure
>> regexp "^[      ]*[a-f0-9]+:    eb 00                   jmp    0x7e$"
>> line   "  7c:   eb 00                   jmp    7e <.text+0x7e>"
>> FAIL: i386 jump
>> ../as-new  --32 -J -o dump.o
>> /usr/local/src/trunk/src/gas/testsuite/gas/i386/ssemmx2.s

  This is HJ's new test for the '$' == '.' syntax.  It looks like a minor
difference between PE and ELF handling of section symbols to me; it doesn't
happen on Linux.  There appears to be an idiom used in the rest of the file to
handle these formatting differences, which I have extended in the attached
patch.  With the patch, cygwin now PASSes and linux remains PASSing.

gas/testsuite/ChangeLog:

	* gas/i386/jump.d:  Tweak patterns to also match PE platform output.

  OK to apply?

    cheers,
      DaveK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gas-jump-test.diff
Type: text/x-c
Size: 894 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20090602/1a538534/attachment.bin>