[PATCH] Update mtfsf and mtfsfi instructions to support new optional operands.
Alan Modra
amodra@bigpond.net.au
Wed Jan 14 22:22:00 GMT 2009
On Wed, Jan 14, 2009 at 04:07:55PM -0600, Peter Bergner wrote:
> opcodes/
> * ppc-dis.c (print_insn_powerpc): Skip insn if it is deprecated.
> * ppc-opc.c (powerpc_opcodes) <mtfsf, mtfsf.>: Deprecate the two
> operand form and enable the four operand form for POWER6 and later.
> <mtfsfi, mtfsfi.>: Deprecate the two operand form and enable the
> three operand form for POWER6 and later.
>
> gas/testsuite/
> * gas/ppc/power6.s ("mtfsf", "mtfsf.", "mtfsfi", "mtfsfi."): Add tests.
> * gas/ppc/power6.d: Likewise.
OK, but..
> diff -u -p -r1.113 ppc-opc.c
> --- opcodes/ppc-opc.c 9 Jan 2009 18:50:58 -0000 1.113
> +++ opcodes/ppc-opc.c 14 Jan 2009 21:45:39 -0000
> @@ -4887,8 +4887,10 @@ const struct powerpc_opcode powerpc_opco
>
> {"dcmpoq", X(63,130), X_MASK, POWER6, PPCNONE, {BF, FRA, FRB}},
>
> -{"mtfsfi", XRC(63,134,0), XWRA_MASK|(3<<21)|(1<<11), COM, PPCNONE, {BFF, U, W}},
> -{"mtfsfi.", XRC(63,134,1), XWRA_MASK|(3<<21)|(1<<11), COM, PPCNONE, {BFF, U, W}},
> +{"mtfsfi", XRC(63,134,0), XRA_MASK|(3<<21)|(1<<11), COM, POWER6, {BFF, U}},
> +{"mtfsfi.", XRC(63,134,1), XRA_MASK|(3<<21)|(1<<11), COM, POWER6, {BFF, U}},
> +{"mtfsfi", XRC(63,134,0), XWRA_MASK|(3<<21)|(1<<11), POWER6, PPCNONE, {BFF, U, W}},
> +{"mtfsfi.", XRC(63,134,1), XWRA_MASK|(3<<21)|(1<<11), POWER6, PPCNONE, {BFF, U, W}},
Reorder this with the two "mtfsfi" followed by two "mtfsfi." Similarly
for mtfsf. I'm trying to keep the table ordered by opcode as much as
possible. (See gas/config/tc-ppc.c:1356.)
--
Alan Modra
Australia Development Lab, IBM
More information about the Binutils
mailing list