[patch]: Patch for wince

Christopher Faylor cgf-use-the-mailinglist-please@sourceware.org
Thu Jan 1 17:23:00 GMT 2009


On Thu, Jan 01, 2009 at 04:58:26PM +0100, Kai Tietz wrote:
>this patch fixes a problem about wince and the windres tool.
>
>ChangeLog
>
>2009-01-01  Kai Tietz  <kai.tietz@onevision.com>
>
>	* windres.c (set_endianess): Cut name between '-' for search.
>
>I tested this patch on mingwce and on x86_64-pc-mingw32.
>
>Is it ok for apply?

I don't think so.  You need to provide more details about what you're fixing.

You shouldn't use "l" (ell) as a variable name because, IMO, it looks
too much like a 1 (one).

And you really, really shouldn't introduce a ^M into source files.

Couldn't you use alloca here to allocate new_tname and avoid a xmalloc?

cgf



More information about the Binutils mailing list