[PATCH] gold: add incremental input structures definitions

Mikolaj Zalewski mikolajz@google.com
Fri Feb 27 17:50:00 GMT 2009


> Mikolaj> diff --git a/elfcpp/elfcpp.h b/elfcpp/elfcpp.h
> Mikolaj> +  SHT_GNU_INCREMENTAL_INPUTS = 0x6ffffff5,
>
> Mikolaj> diff --git a/include/elf/common.h b/include/elf/common.h
> Mikolaj> +#define SHT_GNU_INCREMENTAL_INPUTS 0x6ffffff4   /* incremental build data */
Oops. I'll fix it.

> Also, it seems weird to duplicate constants like this at all, for
> exactly this reason.
One of these is a C #define, while the other is a C++ enum value.
Other SHT_* are also duplicated like that (I will need this only in
C++, but I have also added it to the C file, so that a C developer
doesn't think that this value is not used).

Mikołaj



More information about the Binutils mailing list