[gold patch rfa] print "error: " in front of error messages

[Chris Demetriou]

On Thu, Feb 5, 2009 at 16:41, Ian Lance Taylor <iant@google.com> wrote:
> gold uses overloaded constructors, but it avoids other instances of
> overloaded functions.  I don't see a need for an overload here--I'd
> rather do it a different way.

OK, how about the following?

built i686-linux, tests clean.


chris
----
2009-02-05  Chris Demetriou  <cgd@google.com>

        * gold.h (gold_undefined_symbol): Change to take only a Symbol
        pointer and to report location as the file name associated with
        the symbol.
        (gold_undefined_symbol_at_location): New function to replace the
        old gold_undefined_symbol functionality.
        * symbol.cc (target-reloc.h): Update to use
        gold_undefined_symbol_at_location.
        * symtab.cc (Symbol_table::warn_about_undefined_dynobj_symbol):
        Call gold_undefined_symbol function rather than gold_error.
        * errors.h (Errors::undefined_symbol): Take location as a
        string, rather than calculating it from a relocation.
        * errors.cc (Errors::fatal): Print "fatal error:" before the
        formatted message.
        (Errors::error, Errors::error_at_location): Print "error: "
        before the formatted message.
        (Errors::undefined_symbol): Take location as a string, rather
        than calculating it from a relocation.
        (gold_undefined_symbol_at_location): New function akin to
        old gold_undefined_symbol, calculates location from relocation.
        (gold_undefined_symbol): Change to take only a Symbol pointer
        and to report location as the file name associated with the symbol.
        * testsuite/debug_msg.sh: Update for changed error messages.
        * testsuite/undef_symbol.sh: Likewise.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: err.patch
Type: text/x-patch
Size: 15957 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20090206/4013d30b/attachment.bin>