[gold patch rfa] print "error: " in front of error messages

[Ian Lance Taylor]

Chris Demetriou <cgd@google.com> writes:

> Looking for minor variations on 'error' is likely to be more
> maintainable long-term, especially since plugin errors are likely to
> have the string 'error' as well.  (It's still not perfect, because of
> things like the 'Assertion .* failed' message from failed asserts.
> Could add plugin APIs for diagnostic output and assertions, if they
> aren't there already, but that might be overkill.)
>
>
> Looking further at my patch and all instances of fprintf.stderr in
> gold, I see I missed Errors::error_at_location and
> Errors::undefined_symbol.  If tagging things with "error: " is OK with
> you, I'd want to add it to those as well.

Thanks for the background.  Let's add "error" where needed.
Errors::fatal should use "fatal error", by analogy with gcc.

Ian