[PATCH, 2.20] Fix bug in PE ld: DLL base relocations vs. weak symbols.

Dave Korn dave.korn.cygwin@googlemail.com
Thu Dec 17 17:50:00 GMT 2009


Dave Korn wrote:

> ld/ChangeLog:
> 
> 	* pe-dll.c (generate_reloc): Take account of wrapper options when
> 	testing if a weak symbol is defined or not, and when it is not,
> 	consider whether the default value requires a base reloc anyway.
> 
>   Built and tested on i686-pc-cygwin with no regressions, and it solves the
> testcase that first showed the bug by generating a rebaseable cygstdc++-6.dll.
>  I'm also going to spin a gcc release with the patched binutils and give that
> some testing before I check it in, which will give anyone interested a chance
> to comment.

  JFTR, that all proved itself in testing, so I'll be going ahead and
committing the patch to trunk and branch shortly.

    cheers,
      DaveK




More information about the Binutils mailing list