PR gas/10856

Alan Modra amodra@bigpond.net.au
Sun Dec 6 02:56:00 GMT 2009


On Fri, Dec 04, 2009 at 08:55:26PM -0800, H.J. Lu wrote:
> On Wed, Oct 28, 2009 at 12:21 AM, Alan Modra <amodra@bigpond.net.au> wrote:
> > We already had a test for this PR.  A pity the test expected a wrong
> > result.
> >
> > gas/
> >        PR gas/10856
> >        * expr.c (resolve_expression): Only add "left" value to O_symbol
> >        expression when the symbol is undefined and different from the
> >        original symbol.  Simplify negative logic.
> > gas/testsuite/
> >        * gas/i386/intelpic.d: Correct.
> >
> 
> This patch caused:
> 
> http://sourceware.org/bugzilla/show_bug.cgi?id=11037

Yes.  I'm not sure yet what to do about it, but my initial look says
that the optimisation in resolve_expression for O_add is wrong to
simply set op to O_symbol and expect the later O_symbol code to do the
right thing.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list