[gold][patch] Set the target in make_sized_incremental_binary

Ian Lance Taylor iant@google.com
Thu Dec 3 04:05:00 GMT 2009


Rafael Espindola <espindola@google.com> writes:

> Updated patch attached. I added the name of the file as a function
> argument as is done in object.cc.  Another option would be to add a
> get_name to Output_file.

Yes: add a filename (not get_name) method to Output_file.


> 2009-12-02  Rafael Avila de Espindola  <espindola@google.com>
>
> 	* incremental-dump.cc (main): Update call to open_incremental_binary.
> 	* incremental.cc (make_sized_incremental_binary): Set the target.
> 	Error if it is incompatible.
> 	(open_incremental_binary): Add a name argument. Pass it to
> 	make_sized_incremental_binary.
> 	(Incremental_checker::can_incrementally_link_output_file): Update
> 	call to open_incremental_binary.
> 	* incremental.h (open_incremental_binary): Add a name argument.

This is OK with that change.

Thanks.

Ian



More information about the Binutils mailing list