PATCH: PR ld/10569: -z max-page-size may not work for linker scripts

H.J. Lu hjl.tools@gmail.com
Fri Aug 28 05:50:00 GMT 2009


On Thu, Aug 27, 2009 at 8:14 PM, Alan Modra<amodra@bigpond.net.au> wrote:
> On Thu, Aug 27, 2009 at 05:02:33PM -0700, H.J. Lu wrote:
>>        PR ld/10569
>>        * ldlang.c (lang_add_output_format): Call
>>        bfd_emul_set_maxpagesize/bfd_emul_set_commonpagesize if
>>        maximum/common page sizes are specified and output target
>>        isn't the same as default target.
>
> I think this is the wrong place to call bfd_emul_set_maxpagesize
> (and the current call in elf32.em is wrong too).  You probably should
> be calling bfd_emul_set_maxpagesize in open_output.  Also,

Will open_output be called before any linker scripts are processed?

> bfd_emul_get_maxpagesize in fold_name shouldn't be using
> default_target.  Ditto for commonpagesize.
>

That is true. I will fix it.

-- 
H.J.



More information about the Binutils mailing list