Handle extrdi and large register rotate values

Alan Modra amodra@bigpond.net.au
Fri Aug 28 03:14:00 GMT 2009


On Thu, Aug 27, 2009 at 05:29:36PM -0500, Peter Bergner wrote:
> -{"extrdi",   4,	PPC64,	"rldicl %0,%1,(%2)+(%3),64-(%2)"},
> -{"extrdi.",  4,	PPC64,	"rldicl. %0,%1,(%2)+(%3),64-(%2)"},
> +{"extrdi",   4,	PPC64,	"rldicl %0,%1,((%2)+(%3))&0x3f,64-(%2)"},
> +{"extrdi.",  4,	PPC64,	"rldicl. %0,%1,((%2)+(%3))&0x3f,64-(%2)"},
> 
> but that would mean updating quite a few other ops similarly.  Is the
> following patch acceptable to catch them all in one shot or do you
> prefer a change like the above?

I prefer this.  For your other patch, you'd need to argue that the
current warning on plain rldicl shift counts isn't useful.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list