opcodes: more build fixes

Alan Modra amodra@bigpond.net.au
Mon Aug 24 12:55:00 GMT 2009


On Sun, Aug 23, 2009 at 11:41:05AM +0200, Ralf Wildenhues wrote:
> z8kgen.c documents to generate z8k-opc.h, but there is no
> accompanying rule for this.  Intentional omission?

Unintentional I would say.

> Also, do I assume correctly that i386-gen and ia64-gen only work
> correctly in non-cross-compile situations, and are thus only enabled
> in maintainer-mode?  Because otherwise you wouldn't necessarily be able
> to execute code not compiled with CC_FOR_BUILD.  If that were to be
> changed (similar to how s390-opc.c is created), then the dependency
> tracking wouldn't necessarily work any more for files compiled with
> this.

I think it's a bug that CC_FOR_BUILD isn't used here.

> 	* Makefile.am (TARGET_LIBOPCODES_CFILES): New variable, taken
> 	from $(CFILES), sorted, with dis-buf.c, dis-init.c, disassemble.c,
> 	i386-gen.c, ia64-opc-a.c, ia64-opc-b.c, ia64-opc-f.c, ia64-opc-i.c,
> 	ia64-opc-m.c, ia64-opc-d.c, ia64-gen.c, ia64-asmtab.c removed, and
> 	msp430-dis.c added.
> 	(LIBOPCODES_CFILES): New variable, adding to
> 	TARGET_LIBOPCODES_CFILES also non-target library sources.
> 	(CFILES): Factorize based on $(LIBOPCODES_CFILES), adding generator
> 	files.
> 	(ALL_MACHINES): Factorize based on $(TARGET_LIBOPCODES_CFILES).
> 	(EXTRA_libopcodes_la_SOURCES): Use $(LIBOPCODES_CFILES).
> 	(i386-gen, ia64-gen): Remove.
> 	(noinst_PROGRAMS, i386_gen_LDADD, ia64_gen_LDADD): New variables.
> 	* Makefile.in: Regenerate.
> 	* po/POTFILES.in: Regenerate.

OK.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list