[gold patch rfa] fix output after short writes

Ian Lance Taylor iant@google.com
Fri Apr 24 19:26:00 GMT 2009


Chris Demetriou <cgd@google.com> writes:

> [gold/ChangeLog]
> 2008-04-23  Elliott Hughes  <enh@google.com>
>
>         * output.cc (Output_file::close): After short writes, continue
>         writing from the correct offset in the buffer being written.

Pretty sloppy on my part.

> -          ssize_t bytes_written = ::write(this->o_, this->base_, bytes_to_write);
> +          ssize_t bytes_written = ::write(this->o_, this->base_ + offset, bytes_to_write);

That looks like more than 80 characters, so break the line after the
last comma.

          ssize_t bytes_written = ::write(this->o_, this->base_ + offset,
                                          bytes_to_write);

OK with that change.

Thanks.

Ian



More information about the Binutils mailing list