[patch]: Dump of .pdata/.xdata for x64 coff

Dave Korn dave.korn.cygwin@googlemail.com
Mon Apr 20 12:40:00 GMT 2009


Kai Tietz wrote:

> About the const of the data block. I made it first const, too, like
> you did now. I reverted this, because otherwise we would have to
> redefine a new structure, when we begin to generate those entries.
> Without const we can do without this need. So with the const in
> structures I am not that happy here.

  Ah, I was thinking of crossing that bridge when we came to it, but it
certainly is better to be prepared.  Ok, I removed the const from the struct
members, and then also from pex64_get_unwind_info(); it didn't need removing
from a couple of other places where we're now locally taking const pointers to
non-const data (e.g. insns[] array), so I left them in.

  How do you like this version?  I tested x86_64-pc-mingw32 cross from
i686-pc-cygwin without any problems (and cygwin native, where of course none
of the new code should even come into play), but I don't have any sample files
with .pdata/.xdata to actually test it out on.  I won't re-run the whole big
testsuite on it (not quite finished yet on the earlier version), I'll infer
that if the results don't change on x86_64 by de-consting these things, and it
still compiles without error, then the same would apply to all the other
targets ...

    cheers,
      DaveK

-------------- next part --------------
A non-text attachment was scrubbed...
Name: xdata_peix64-respun-2.diff
Type: text/x-c
Size: 23954 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20090420/3c70193a/attachment.bin>


More information about the Binutils mailing list