2.19 -enable-targets=all one error in m68k-dis.c due to longjmp, easily fixed with volatile

Nick Clifton nickc@redhat.com
Mon Nov 24 17:51:00 GMT 2008


Hi Andreas,

>> + static fprintf_ftype save_printer;
>> + static void (* save_print_address) (bfd_vma, struct disassemble_info *);
> 
> This is wrong, these variables are never set.  The save/restore part
> should be completely local to match_insn_m68k, no other function should
> need to touch them.

Good point - that was a hold over from a previous version of the patch. 
  Sorry.

Cheers
   Nick




More information about the Binutils mailing list