[Patch/committed] Avoid new 'pointer targets...differ in signedness' warning in dlltool.c

Danny Smith dansmister@gmail.com
Sun Nov 16 06:06:00 GMT 2008


Hello,

Using gcc trunk,  compilation of dlltool.c fails following this patch

2008-11-15  Charles Wilson  <cygwin at cwilson dot fastmail.fm>

	Added --identify option to dlltool.

cc1.exe: warnings being treated as errors
../../src/binutils/dlltool.c: In function 'identify_search_section':
../../src/binutils/dlltool.c:3109: error: pointer targets in passing argument 1
of 'xstrdup' differ in signedness

This fixes and has been committed as obvious.

binutils/ChangeLog

2008-11-16  Danny Smith  <dannysmith@usesr.sourceforge.net>

	* dlltool.c (identify_search_section): Cast argument, not return
	value, of xstrdup to 'char*'.

Danny


Index: dlltool.c
===================================================================
RCS file: /cvs/src/src/binutils/dlltool.c,v
retrieving revision 1.84
diff -c -3 -p -r1.84 dlltool.c
*** dlltool.c	15 Nov 2008 18:15:18 -0000	1.84
--- dlltool.c	16 Nov 2008 05:54:34 -0000
*************** identify_search_section (bfd *abfd, asec
*** 3106,3112 ****
                free (identify_dll_name);
              }
          }
!       identify_dll_name = (char*) xstrdup (data);
      }

    free (data);
--- 3106,3112 ----
                free (identify_dll_name);
              }
          }
!       identify_dll_name = xstrdup ((char*) data);
      }

    free (data);



More information about the Binutils mailing list