PING : [PATCH] Add support for Xilinx FP/APU to PowerPC

Alan Modra amodra@bigpond.net.au
Tue May 27 05:56:00 GMT 2008


On Fri, May 23, 2008 at 01:51:43PM -0700, Michael Eager wrote:
> Could someone please check this in?

No, it has some errors I think.  I glanced at it a month ago, saw
one error and put it aside for a proper review, then forgot about it.
Sorry for the delay.

> +/* Opcode is supported by PowerPC 405 processor.  */
> +#define PPC_OPCODE_405		 0x10000000

Reuse PPC_OPCODE_PPCPS??

>  {"nmaclhwso.",	XO (4, 494,1,1),XO_MASK, PPC405|PPC440,	{RT, RA, RB}},
> +
> +{"get",      	APU(4,536), 	APU_RA_MASK,	PPC405 | PPC32,		{ RT, FSL } },

This isn't the right place to insert these new opcodes.  I'm trying to
keep the table more or less sorted, so that you can more easily see
when cpu variants use the same opcode for different instructions.
So "get" ought to go after "evnot", "cget" after "evcmpeq" and so on.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list