[PATCH] CR16 target specific fix

M R Swami Reddy MR.Swami.Reddy@nsc.com
Wed May 21 07:27:00 GMT 2008


Hi Nick,
Thank you very much for review and suggestion.
Please find the updated the patch as per your comment.

Thanks,
Swami

===================================================================
RCS file: /cvs/src/src/opcodes/cr16-dis.c,v
retrieving revision 1.3
diff -c -r1.3 cr16-dis.c
*** cr16-dis.c  5 Jul 2007 09:49:00 -0000       1.3
--- cr16-dis.c  21 May 2008 07:23:57 -0000
***************
*** 307,312 ****
--- 307,316 ----
   build_mask (void)
   {
     unsigned long mask = SBM (instruction->match_bits);
+   /* Adjust mask for bcond with 32-bit size instruction.  */
+   if ((IS_INSN_MNEMONIC("b") && instruction->size == 2))
+     mask = 0xff0f0000;
+
     return mask;
   }
=====================================================================

Nick Clifton wrote:
> Hi Swami,
> 
>>       {
>>         mask = build_mask ();
>> +       /* Adjust mask for bcond with 32-bit size instruction.  */
>> +       if ((IS_INSN_MNEMONIC("b") && instruction->size == 2))
>> +         mask = 0xff0f0000;
>> +
> 
> Wouldn't it be better cleaner if this code was inside build_mask() ?
> 
> Cheers
>   Nick
> 
> 
> 



More information about the Binutils mailing list