PATCH COMMITTED: Fix section groups in objects with many sections

Ian Lance Taylor iant@google.com
Mon May 5 19:19:00 GMT 2008


Gold was not correctly handling section groups in object with many
sections, in the case where the object was created by a version of the
GNU binutils from before the fix for PR 5900.  I committed this patch
to fix it.  I added a template to the many sections test, which causes
the bug to appear.

Ian


2008-05-05  Ian Lance Taylor  <iant@google.com>

	* object.cc (Sized_relobj::include_section_group): Adjust section
	indexes read from group data.  Build vector to pass to
	layout_group.
	* layout.cc (Layout::layout_group): Add flags and shndxes
	parameters.  Remove contents parameter.  Change caller.  Update
	explicit instantiations.
	* layout.h (class Layout): Update layout_group declaration.
	* output.cc (Output_data_group::Output_data_group): Add flags and
	input_shndxes parameters.  Remove contents parameter.  Change
	caller.
	(Output_data_group::do_write): Change input_sections_ to
	input_shndxes_.
	* output.h (class Output_data_group): Update constructor
	declaration.  Rename input_sections_ to input_shndxes_.
	* testsuite/many_sections_test.cc: Add template.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: foo.patch
Type: text/x-patch
Size: 8175 bytes
Desc: Fix section groups in objects with many sections
URL: <https://sourceware.org/pipermail/binutils/attachments/20080505/c37c95d8/attachment.bin>


More information about the Binutils mailing list