[PATCH][m68k] Support generation of multiple GOTs

Maxim Kuvyrkov maxim@codesourcery.com
Thu Mar 27 17:41:00 GMT 2008


Andreas,

thank you for the review.  Below are my comments.

Andreas Schwab wrote:
> Maxim Kuvyrkov <maxim@codesourcery.com> writes:

...

>> +AC_ARG_ENABLE([got],
>> +AS_HELP_STRING([--enable-got=<type>],
>> +               [GOT handling scheme (target, single, negative, multigot)]),
>> +[case "${enableval}" in
>> +  target | single | negative | multigot)  got_handling=$enableval ;;
>> +  *)  AC_ERROR(bad value ${enableval} for --enable-got option) ;;
>> +esac],
>> +[got_handling=target])
> 
> I don't think we need that configure option.  Passing the right option
> by default via gcc should be enough.

I thought of that, but the choice of the default setting is really 
dependent on the glibc version installed on a particular system.  This 
is due to glibc's dynamic linker making assumptions about GOT pointer. 
Hence I introduced the configure option.

I'll fix all other issues you pointed out.

Also I forgot to attach new test files for the ld-m68k testsuite in my 
original message.  Here they are.

--
Maxim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: got-tests.tar.bz2
Type: application/octet-stream
Size: 96832 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20080327/4b389b5b/attachment.obj>


More information about the Binutils mailing list