[PATCH] bug 5543: do not allow register symbols to be global

Nick Clifton nickc@redhat.com
Mon Mar 3 14:59:00 GMT 2008


Hi H.J.

> gas/
> 2008-03-02  Denys Vlasenko <vda.linux@googlemail.com>
> 	    H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR gas/5543
> 	* read.c (pseudo_set): Don't allow global register symbol.
> 
> 	* symbols.c (S_SET_EXTERNAL): Don't allow register symbol
> 	global.
> 
> 2008-03-02  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR gas/5543
> 	* write.c (write_object_file): Don't allow symbols which were
> 	equated to register.  Stop if there is an error.
> 
> gas/testsuite/
> 2008-03-02  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR gas/5543
> 	* gas/i386/i386.exp: Run inval-equ-1 and inval-equ-2.
> 
> 	* gas/i386/inval-equ-1.l: New.
> 	* gas/i386/inval-equ-1.s: Likewise.
> 	* gas/i386/inval-equ-2.l: Likewise.
> 	* gas/i386/inval-equ-2.s: Likewise.

Approved - please apply.

Note: I think that the error message in pseudo_set() is a little
unclear.  How about this instead ?

   cannot equate global symbol '%s' with register name


Cheers
   Nick



More information about the Binutils mailing list