PATCH COMMITTED: Fix overflow warnings by deleting code

Ian Lance Taylor iant@google.com
Mon Jun 30 18:42:00 GMT 2008


I took a closer look at the overflow warnings in gold/powerpc.cc.
They are actually from code that is unused.  The existing code loads a
16-bit value and then clears the low 16 bits.  That is pointless.  I
deleted that code, which eliminates the overflow warnings.

I also changed the code to use the template endianness when writing
out the value, which seems like the right thing to do and is
consistent with the other relocation handling.

Ian


2008-06-30  Ian Lance Taylor  <iant@google.com>

	PR 6660
	PR 6682
	* powerpc.cc (Powerpc_relocate_functions::addr16_ha) [both
	versions]: Don't try to read the value in the contents, since we
	don't use it.  Use the template endianness when writing.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: foo.patch
Type: text/x-patch
Size: 1727 bytes
Desc: Delete ineffective code
URL: <https://sourceware.org/pipermail/binutils/attachments/20080630/51d5a023/attachment.bin>


More information about the Binutils mailing list