Feature request: Set the direction flag on x86/x64 register->register operations
H.J. Lu
hjl.tools@gmail.com
Sat Dec 20 00:34:00 GMT 2008
On Fri, Dec 19, 2008 at 7:25 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Dec 19, 2008 at 1:07 AM, Jan Beulich <jbeulich@novell.com> wrote:
>>>>> Stefan Dösinger<stefan@codeweavers.com> 19.12.08 01:52 >>>
>>>I had to regenerate opcodes/i386-tbl.h, but now it works like a charm!
>>>Objdump also disassembles the opcodes properly with the .r suffix
>>
>> I would strongly suggest to print to .r only with -Msuffix.
>
> Good point. I will do that.
>
>> Also, the whole thing seems half-baked to me, as it only deals with
>> alternative encodings using the 'D' bit. Using an .a suffix and handling
>
> ".r" handles insns which can be encoded differently by swapping operands
> in encoding:
>
> fadd %st,%st
> fadd.r %st,%st
> fdiv %st,%st
>
> I think ".s" a better name. I will change ".r" to ".s".
>
Here is the updated patch. I changed ".r" to ".s". I also
removed FloatD since you can encode them differently
with %st vs %st(0). Stefan, does it work for you?
--
H.J.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: binutils-option-3.patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20081220/9f884623/attachment.ksh>
More information about the Binutils
mailing list