[gold][patch] Change how to specify options for the plugins

[Ian Lance Taylor]

Rafael Espindola <espindola@google.com> writes:

> 2008-12-04  Rafael Avila de Espindola  <espindola@google.com>
>
> 	* options.cc (General_options::parse_plugin_opt): New.
> 	(General_options::add_plugin): The argument now is just the filename.
> 	(General_options::add_plugin_option): New.
> 	* options.h (plugin_opt): New.
> 	(add_plugin): Change argument name.
> 	(add_plugin_option): New.
> 	* plugin.cc (Plugin::load): Don't parse the plugin option.
> 	* plugin.h (Plugin::Plugin): Rename argument. Init filename_.
> 	(Plugin::add_option): New.
> 	(Plugin::args_): Change type.
> 	(Plugin::filename_): New.
> 	(Plugin_manager::add_plugin_option): New.
> 	* testsuite/Makefile.am (plugin_test_1): Use new syntax.
> 	* testsuite/Makefile.in: Regenerate.
> +
> +//Parse --plugin-opt.
> +

Please add a space between "//" and "Parse".

> +  DEFINE_special(plugin_opt, options::TWO_DASHES, '\0',
> +                 N_("pass an option to the plugin"), N_("OPTION"));

Please capitalize "pass".

This is OK with those changes.

Thanks.

Ian