[PATCH gold/6859] Symbols specified as -u <symbol> may erroneously get added to dynsym

Ian Lance Taylor iant@google.com
Wed Aug 27 16:22:00 GMT 2008


Kris Van Hees <kris.van.hees@oracle.com> writes:

> 2008-08-26  Kris Van Hees  <kris.van.hees@oracle.com>
>
> 	PR 6859
>         * symtab.cc (Symbol::init_base_undefined): Mark explicitly undefined
> 	symbols as not needing a dynsym entry.
>
> Patch:
> ======
> Index: gold/symtab.cc
> ===================================================================
> RCS file: /cvs/src/src/gold/symtab.cc,v
> retrieving revision 1.107
> diff -r1.107 symtab.cc
> 176a177
>>   this->dynsym_index_ = -1;

Please write -1U.  This is OK with that change.

By the way, diffs are easier to understand if you generate them with
-up or plain -p.

Thanks.

Ian



More information about the Binutils mailing list