relocs_compatible hook considered harmful

Alan Modra amodra@bigpond.net.au
Thu Apr 24 01:07:00 GMT 2008


On Wed, Apr 23, 2008 at 11:39:49AM -0400, Daniel Jacobowitz wrote:
> Alan's patch for PR 2434 introduced a guard on the call to
> check_relocs.  Any time this returns false, check_relocs will not be
> called.  But relocate_section gets called anyway.

Err, I think you have the wrong patch.  The PR2423 fix didn't make
functional changes in this area.  The most recent functional change in
the way check_relocs was called, prior to relocs_compatible, was
http://sourceware.org/ml/binutils/2003-12/msg00001.html.
Also, _bfd_elf_default_relocs_compatible does exactly as prior to
relocs_compatible, so I'm a little mystified by your subject line.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list