PATCH: Add tests for pmuludq, paddq and psubq

Hans-Peter Nilsson hp@bitrange.com
Wed Apr 23 15:53:00 GMT 2008


On Wed, 23 Apr 2008, H.J. Lu wrote:

> x86 assembler testsuite doesn't cover pmuludq, paddq and psubq in
> SSE2.  I am checking this patch to add them.
>
>
> H.J.
> ----
> 2008-04-23  H.J. Lu  <hongjiu.lu@intel.com>
>
> 	* gas/i386/sse2.s: Add tests for pmuludq, paddq and psubq.
> 	* gas/i386/x86-64-simd.s: Likewise.
>
> 	* gas/i386/sse2.d: Updated.
> 	* gas/i386/x86-64-simd.d: Likewise.
> 	* gas/i386/x86-64-simd-intel.d: Likewise.
> 	* gas/i386/x86-64-simd-suffix.d: Likewise.

If it had been me, for a change described as "Add tests", I'd
add new test files instead of patching old ones; seems to be
about the same work but better traceability, for one reason.
But that's just me.  Maybe there was also a reason for shuffling
around stuff in the old test; not just adding, one not declared
in the ChangeLog.

brgds, H-P



More information about the Binutils mailing list