broken testresults with "[PATCH] decoded output of .debug_line from readelf -wL"

Hans-Peter Nilsson hp@bitrange.com
Fri Apr 11 17:16:00 GMT 2008


On Fri, 11 Apr 2008, Nick Clifton wrote:
> Anyway to save you some time I have applied your patch, along with this
> correction, and another fix.  (You forgot to implement the long version of the
> command line switch, ie --debug-debug=decodedline).  I also created a
> ChangeLog entry for you and fixed up the formatting problems.

> binutils/ChangeLog
> 2008-04-11  Torleif Sandnes  <torleif.sandnes@gmail.com>
>
> 	* dwarf.c (display_debug_lines): Rename to
> 	display_debug_lines_raw.
> 	(display_debug_lines_decoded): New function.  Displays the
> 	interpreted contents of a .debug_line section.
> 	(display_debug_lines): New function: Selects either a raw dump or
> 	a decoded dump (or both) as requested by the user.
> 	* dwarf.h (do_debug_lines_decoded): New extern.
> 	* readelf.c: Add support for -wL or --debug-dump=decodedline
> 	option to display the decoded contents of a .debug_line section.
> 	* doc/binutils.texi: Document the new option.
> 	* NEWS: Mention the new feature.
>

Unfortunately, it broke testresults for at least cris-elf and
native x86_64-unknown-linux-gnu; at a glance it seems -wl is
misinterpreted as -wL or something:

Running /home/hp/binutils/src/gas/testsuite/gas/lns/lns.exp ...
FAIL: lns-duplicate
FAIL: lns-common-1

gas.log (cutnpasted):
/home/hp/binutils/o/native/gas/testsuite/../../binutils/readelf  -wl dump.o
Executing on host: sh -c {/home/hp/binutils/o/native/gas/testsuite/../../binutils/readelf  -wl dump.o >dump.out 2>gas.stderr}  /dev/null  (timeout = 300)
regexp_diff match failure
regexp "^Dump of debug contents of section \.debug_line:$"
line   "Raw dump of debug contents of section .debug_line:"
FAIL: lns-duplicate
../as-new   -o dump.o /home/hp/binutils/src/gas/testsuite/gas/lns/lns-common-1.s
Executing on host: sh -c {../as-new   -o dump.o
/home/hp/binutils/src/gas/testsuite/gas/lns/lns-common-1.s 2>&1}  /dev/null gas.out (timeout = 300)
/home/hp/binutils/o/native/gas/testsuite/../../binutils/readelf  -wl dump.o
Executing on host: sh -c {/home/hp/binutils/o/native/gas/testsuite/../../binutils/readelf
-wl dump.o >dump.out 2>gas.stderr}  /dev/null  (timeout = 300)
regexp_diff match failure
regexp "^Dump of debug contents of section \.debug_line:$"
line   "Raw dump of debug contents of section .debug_line:"
FAIL: lns-common-1

brgds, H-P



More information about the Binutils mailing list