CVS HEAD broken for x86_64-pc-mingw32

[Kai Tietz]

binutils-owner@sourceware.org wrote on 11.04.2008 03:08:55:

> Building binutils with:
> build=x86_64-pc-linux
> host=x86_64-pc-mingw32
> target=x86_64-pc-mingw32
> 
> no longer works:
> 
> x86_64-pc-mingw32-gcc -DHAVE_CONFIG_H -I. -I../../src/gas -I. -I.
> -I../../src/gas -I../bfd -I../../src/gas/config
> -I../../src/gas/../include -I../../src/gas/.. -I../../src/gas/../bfd
> -I./../intl -DLOCALEDIR="\"/var/tmp/root-x86_64-pc-mingw/share/locale\""
>   -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wno-format
> -Werror -g -O2 -c ../../src/gas/listing.c
> cc1: warnings being treated as errors
> ../../src/gas/listing.c: In function 'print_timestamp':
> ../../src/gas/listing.c:1072: error: implicit declaration of function
> 'localtime_r'
> make[4]: *** [listing.o] Error 1
> make[4]: Leaving directory `/var/tmp/build/binutils/w64/gas'
> make[3]: *** [all-recursive] Error 1
> make[3]: Leaving directory `/var/tmp/build/binutils/w64/gas'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/var/tmp/build/binutils/w64/gas'
> make[1]: *** [all-gas] Error 2
> make[1]: Leaving directory `/var/tmp/build/binutils/w64'
> make: *** [all] Error 2
> 

Yes, the function localetime_r () is currently not supported by 
mingw/mingw-w64 in time.h. I will add for mingw-w64 in time.h a macro 
implementing this, but for mingw there is still a lack of support (beside 
including pthreads). The static buffer returned by localtime call is using 
thread-specific buffer on win32. So the localtime function (and the macro 
localtime_r) is thread-safe.
But for backward compatibility issue may this call should be modified to 
use localtime()

Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.