Ping Re: Patch for MIPS multi-got bug with forced-local symbols

[Richard Sandiford]

Daniel Jacobowitz <drow@false.org> writes:
> I see two solutions.  One is to avoid setting got.offset for forced
> local symbols, and set it back to MINUS_ONE when hiding symbols.
> The other is to set got.offset but still not put such symbols in the
> global GOT when the time comes.
>
> The second is easier, since we use got.offset != MINUS_ONE in
> mips_elf_record_global_got_symbol to detect symbols with already
> allocated GOT entries.  This patch implements that.  It fixes
> Joseph's two new testcases, which should be committed along
> with it.  I'm going to start more intensive testing now.
>
> Anyone have comments on this patch?

FWIW, it looks good to me.  I think the second solution is indeed how
things are supposed to work at the moment, and if we're going to change
the datastructures, a bigger overhaul than the first option might be
useful...

Richard