pr 5328

Alan Modra amodra@bigpond.net.au
Thu Nov 15 05:20:00 GMT 2007


Applied.

	PR 5328
	* opncls.c (separate_debug_file_exists): Use fopen/fread
	rather than open/read and open in binary mode.

Index: bfd/opncls.c
===================================================================
RCS file: /cvs/src/src/bfd/opncls.c,v
retrieving revision 1.50
diff -u -p -r1.50 opncls.c
--- bfd/opncls.c	14 Sep 2007 07:54:10 -0000	1.50
+++ bfd/opncls.c	15 Nov 2007 05:07:05 -0000
@@ -1175,19 +1175,19 @@ separate_debug_file_exists (const char *
 {
   static unsigned char buffer [8 * 1024];
   unsigned long file_crc = 0;
-  int fd;
+  FILE *f;
   bfd_size_type count;
 
   BFD_ASSERT (name);
 
-  fd = open (name, O_RDONLY);
-  if (fd < 0)
+  f = real_fopen (name, FOPEN_RB);
+  if (f == NULL)
     return FALSE;
 
-  while ((count = read (fd, buffer, sizeof (buffer))) > 0)
+  while ((count = fread (buffer, 1, sizeof (buffer), f)) > 0)
     file_crc = bfd_calc_gnu_debuglink_crc32 (file_crc, buffer, count);
 
-  close (fd);
+  fclose (f);
 
   return crc == file_crc;
 }

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list