[PATCH] MIPS BFD: Avoid unwanted fallthroughs in elfxx-mips.c

Thiemo Seufer ths@networkno.de
Wed Nov 14 20:07:00 GMT 2007


Hello All,

I committed the appended patch, it fixes a logic bug which caused
in some cases two lines of output, only one of them valid.


Thiemo


2007-11-14  Thiemo Seufer  <ths@mips.com>

	* elfxx-mips.c (mips_elf_merge_obj_attributes): Prevent
	unwanted fallthroughs in case statement.

Index: head/bfd/elfxx-mips.c
===================================================================
--- head.orig/bfd/elfxx-mips.c	2007-11-14 19:01:31.000000000 +0000
+++ head/bfd/elfxx-mips.c	2007-11-14 19:15:45.000000000 +0000
@@ -11073,6 +11073,7 @@
 		_bfd_error_handler
 		  (_("Warning: %B uses -msingle-float, %B uses -mdouble-float"),
 		   obfd, ibfd);
+		break;
 
 	      case 3:
 		_bfd_error_handler
@@ -11092,6 +11093,7 @@
 		_bfd_error_handler
 		  (_("Warning: %B uses -msingle-float, %B uses -mdouble-float"),
 		   ibfd, obfd);
+		break;
 
 	      case 3:
 		_bfd_error_handler



More information about the Binutils mailing list