PATCH: PR binutils/5233: objcopy won't change section flags on zero file-size sections

[Andrew STUBBS]

H.J. Lu wrote:
> Here is the patch for testcase. This change:
> 
> --- elf.c.flags 2007-10-30 10:51:02.000000000 -0700
> +++ elf.c       2007-10-30 14:10:46.000000000 -0700
> @@ -5557,12 +5557,14 @@ rewrite_elf_program_header (bfd *ibfd, b
>           *pointer_to_map = map;
>           pointer_to_map = &map->next;
>  
> +#if 0
>           if (matching_lma != map->p_paddr
>               && !map->includes_filehdr && !map->includes_phdrs)
>             /* There is some padding before the first section in the
>                segment.  So, we must account for that in the output
>                segment's vma.  */
>             map->p_vaddr_offset = matching_lma - map->p_paddr;
> +#endif
>  
>           free (sections);
>           continue;
> 
> will fix this regression.

Are there any unpleasant side-effects from removing this code?

Andrew