[PATCH] Optimize ldlang_add_file for large input quantities

Noah Misch noah@cs.caltech.edu
Mon May 28 12:48:00 GMT 2007


On Mon, May 28, 2007 at 01:04:04PM +0930, Alan Modra wrote:
> On Sat, May 26, 2007 at 08:47:16AM -0700, Noah Misch wrote:
> > 	include/
> > 	* bfdlink.h (struct bfd_link_info): Add input_bfds_tail.
> > 	
> > 	ld/
> > 	* ldlang.c (ldlang_add_file): Use input_bfds_tail.
> 
> Have you audited all bfd and ld code that touches input_bfds to ensure
> that no other place inserts or deletes list elements?  If you find
> such a place then it might need to update input_bfds_tail..

I audited that to the best of my ability.  Of the numerous input_bfds consumers,
only ldlang_add_file appears to modify the structure of the list.



More information about the Binutils mailing list