patch: windres allows string concat

Nick Clifton nickc@redhat.com
Thu May 24 09:25:00 GMT 2007


Hi Kai,

> This patch allows that "rc"-parser joins strings for style's CAPTION, 
> CLASS, FONT (names), and for menu elements MENUITEM & POPUP, and also for 
> version VALUE text elements.

Did you test this patch ?  If so, how ?
[As a general point you should always test patches and always report how 
you tested them.  Eg in this case by rerunning the binutils testsuite 
for windres using toolchain and showing that there are no regressions].

Also, since you are adding a new feature, it would be a good idea if you 
could add a new testcase to check it.

Cheers
   Nick



More information about the Binutils mailing list