patch: Updated windres tool Part 1 of 2
Dave Korn
dave.korn@artimi.com
Tue May 22 14:40:00 GMT 2007
On 22 May 2007 15:32, Nick Clifton wrote:
> Hi Kai,
>
>> I am really uncertain about this. The fix is quite simple by allocating
>> the output buffer using a 4 bytes alignment in "resres.c".
>
> Lets do that then. (Fewer changes to other files == better in my opinion).
>
>>> /* Use bfd_size_type to ensure a sufficient number of bits. */
>>> typedef rc_bitfield_type bfd_size_type;
>
>> This sounds fine. I am agreeing to that. I will walk over the code for
>> this. I would prefer as name something like rc_int_type. Is that ok ?
>
> Yes this is fine. My name was just a suggestion.
The name should probably convey whether it's signed or not, shouldn't it?
Size types are usually unsigned - perhaps rc_uint_type would be best of all?
cheers,
DaveK
--
Can't think of a witty .sigline today....
More information about the Binutils
mailing list