A question on ACX_BUGURL
Paolo Bonzini
paolo.bonzini@lu.unisi.ch
Mon Mar 26 09:01:00 GMT 2007
> + no) BUGURL="";
just BUGURL= (no useless trailing semicolon).
> + case ${BUGURL} in
Please quote this as "$BUGURL".
> + REPORT_BUGS_TO="<$BUGURL>"
> + REPORT_BUGS_TEXI="@uref{`echo $BUGURL | sed 's/@/@@/g'`}"
Please do this instead:
REPORT_BUGS_TEXI=@uref{`echo "$BUGURL" | sed 's/@/@@/g'`}
as suggested by Andreas. Quoting is "less" necessary in variable
assignments (it is still necessary for REPORT_BUGS_TO because
of the less-than/greater-than signs).
Otherwise seems okay, but please resubmit.
Paolo
More information about the Binutils
mailing list