PATCH: Fixing build problem in bfd

H. J. Lu hjl@lucon.org
Wed Mar 7 14:43:00 GMT 2007


On Wed, Mar 07, 2007 at 12:53:19PM +0100, Kai Tietz wrote:
> Hallo,
> 
> There is a build failure in bfd. The type reloc_howto_type, which is 
> allready defined as const, was declared as const a second time. This leads 
> to a warning and a build-failure.
> This patch should solve this problem.

I checked in this patch as an obvious fix.

> 
> Regards,
> i.A. Kai Tietz
> 
> ChangeLog:
> 
> 2007-03-07  Kai Tietz   <kai.tietz@onevision.com>
> 
>         * reloc.c: (bfd_generic_get_relocated_section_contents) Too much 
> const for type reloc_howto_type
> 

Your ChangeLog entry is too long and `:' should be after `)'.

> 
> Patch:
> Index: bfd/reloc.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/reloc.c,v
> retrieving revision 1.162
> diff -b -u -r1.162 reloc.c
> --- reloc.c     7 Mar 2007 08:54:34 -0000       1.162
> +++ reloc.c     7 Mar 2007 11:46:03 -0000
> @@ -5155,7 +5155,7 @@
>           if (symbol->section && elf_discarded_section (symbol->section))
>             {
>               bfd_byte *p;
> -             static const reloc_howto_type none_howto
> +             static reloc_howto_type none_howto
>                 = HOWTO (0, 0, 0, 0, FALSE, 0, complain_overflow_dont, 
> NULL
>                          "unused", FALSE, 0, 0, FALSE);

Your patch won't apply due to white spaces.

This is what I committed.


H.J.
---
2007-03-07  Kai Tietz   <kai.tietz@onevision.com>

	* reloc.c (bfd_generic_get_relocated_section_contents): Remove
	const for type reloc_howto_type.

Index: reloc.c
===================================================================
RCS file: /cvs/src/src/bfd/reloc.c,v
retrieving revision 1.162
diff -u -p -r1.162 reloc.c
--- reloc.c	7 Mar 2007 08:54:34 -0000	1.162
+++ reloc.c	7 Mar 2007 14:38:32 -0000
@@ -5155,7 +5155,7 @@ bfd_generic_get_relocated_section_conten
 	  if (symbol->section && elf_discarded_section (symbol->section))
 	    {
 	      bfd_byte *p;
-	      static const reloc_howto_type none_howto
+	      static reloc_howto_type none_howto
 		= HOWTO (0, 0, 0, 0, FALSE, 0, complain_overflow_dont, NULL,
 			 "unused", FALSE, 0, 0, FALSE);
 



More information about the Binutils mailing list