PATCH: PR gas/3918: make check RUNTESTFLAGS=i386.exp doesn't work

Ben Elliston bje@au1.ibm.com
Tue Mar 6 00:35:00 GMT 2007


On Mon, 2007-03-05 at 13:00 -0800, H. J. Lu wrote:

> The problem is gas_finish. runtest.exp will call ${tool}_finish if it
> exists. But gas_finish isn't intended to be called by runtest.exp
> and should only be used with gas_start. When
> 
> # make check RUNTESTFLAGS=i386.exp
> 
> is used, gas_finish is called without gas_start and closes the wrong
> fd. We can rename gas_finish. But it is used in 250 places. This patch
> adds gas_started to make sure that it will be used when gas_start.

This patch is okay, but please add a comment above "set gas_started 1"
to explain why this variable is needed.  Approved with this change.

Ben




More information about the Binutils mailing list