PATCH: Don't match PE/EFI target with EFI/PE file

H.J. Lu hjl@lucon.org
Thu Jul 5 03:59:00 GMT 2007


On Thu, Jul 05, 2007 at 01:19:33AM +0100, Pedro Alves wrote:
> Alan Modra wrote:
> >On Mon, Jun 18, 2007 at 05:10:14PM +0100, Nick Clifton wrote:
> >>>2007-06-09  H.J. Lu  <hongjiu.lu@intel.com>
> >>>
> >>>	* libpei.h (_bfd_XXi_final_link_postscript): Remove
> >>>	duplication.
> >>>	(bfd_target_pei_p): New.
> >>>	(bfd_target_pei_arch): New
> >>>	(bfd_target_efi_p): Likewise.
> >>>	(bfd_target_efi_arch): New
> >>>	(bfd_pe_executable_p): Use bfd_target_pei_p and
> >>>	bfd_target_efi_p.
> >>>
> >>>	* peicode.h (arch_type): New enum.
> >>>	(pe_arch): New function.
> >>>	(pe_bfd_object_p): Don't match PE/EFI target with EFI/PE file
> >>>	if there is an EFI/PE target.
> >>Approved - please apply.
> >
> >I believe this patch is responsible for multiple testsuite failures on
> >non-x86 pe targets.  eg. arm-wince-pe and mcore-pe.  HJ would you
> >please look into it?
> >
> 
> I was just looking at it, as it also breaks gdb.
> 
> This is what I have now.  Minimally tested on arm-wince.  It should also
> fix epoc, but I haven't tested it yet.  (Posted to minimize work
> duplication with HJ - be my guest to pick it up.)
> 
> Cheers,
> Pedro Alves
> 

> 2007-07-05  Pedro Alves  <pedro_alves@portugalmail.pt>
> 
> 	* libpei.h (bfd_target_pei_p): Handle "epoc-pei".
> 	(bfd_target_pei_arch): Likewise.
> 	* peicode.h (arch_type): Add arch_type_arm_little and
> 	arch_type_arm_big.
> 	(pe_arch): Handle arm-wince-little, arm-little, arm-wince-big
> 	and arm-big.
> 

Checked in a different fix. Since both PE and EFI are only supported
on x86 and x86-64, there is no need to check for other archs.


H.J.



More information about the Binutils mailing list