[PATCH] Fix Score bugs.

ligang@sunnorth.com.cn ligang@sunnorth.com.cn
Fri Jan 19 01:47:00 GMT 2007


Hi, H.J.,


"H. J. Lu" <hjl@lucon.org> wrote on 2007-01-18 21:58:08:

> On Thu, Jan 18, 2007 at 06:37:57PM +0800, ligang@sunnorth.com.cn wrote:
> > @@ -2395,7 +2396,7 @@ append_insn (char *str, bfd_boolean gen_
> >    if (inst.error)
> >      {
> >        retval = (int) FAIL;
> > -      as_bad ("%s -- `%s'", inst.error, inst.str);
> > +      as_bad (_("%s -- `%s'"), inst.error, inst.str);
> 
> _() isn't needed here.
> 
> >        inst.error = NULL;
> >      }
> > 
> > @@ -2437,7 +2438,7 @@ do16_mv_rdrs (char *str)
> >              {
> >                char append_str[MAX_LITERAL_POOL_SIZE];
> > 
> > -              sprintf (append_str, "mlfh! %s", backupstr);
> > +              sprintf (append_str, _("mlfh! %s"), backupstr);
> 
> I don't think _() is needed for mnemonics. Please fix them.

In fact, I am a little confused about How to use _().
What case is _() needed, and what case not needed? 

> >                      Ligang
> 
> 
> H.J.



More information about the Binutils mailing list