[PATCH] mips: Print extra elf header flags.
Carlos O'Donell
carlos@codesourcery.com
Fri Feb 16 23:38:00 GMT 2007
On Fri, Feb 16, 2007 at 05:24:34PM -0500, Hans-Peter Nilsson wrote:
> On Fri, 16 Feb 2007, Carlos O'Donell wrote:
> > + if (elf_elfheader (abfd)->e_flags & EF_MIPS_NOREORDER)
> > + fprintf (file, _(" [.noreorder]"));
>
> I suggest you drop the _() on all these or else the translation
> team may be tempted to translate these strings to every
> (supported) human language. ;-)
I was blindly following the function convention, which uses _() for all
the output flags.
Is it a bad thing to mark all strings with _()? It's certainly an easier
rule than "Use your discretion" :-)
Cheers,
Carlos.
--
Carlos O'Donell
CodeSourcery
carlos@codesourcery.com
(650) 331-3385 x716
More information about the Binutils
mailing list