PATCH: Map GNU attributes section to PT_GNU_ATTR (aka PT_GNU_STACK) segment

Nick Clifton nickc@redhat.com
Thu Aug 16 10:30:00 GMT 2007


Hi H.J.

> I am not sure if it is worth the change since a special note section,
> .note.GNU-stack, is used to specify the stack flags. Moving it to
> the .gnu.attributes section will require changes in gcc, binutils
> and applications. We have to keep .note.GNU-stack because of it. We
> can add new ones to .gnu.attributes, but should leave the stack flags
> alone.

Good point - OK, lets stick with what you have.

> bfd/
> 2007-08-15  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* elf.c (get_segment_type): Change PT_GNU_STACK to PT_GNU_ATTR.
> 	(bfd_section_from_phdr): Likewise.
> 	(get_program_header_size): Likewise. Add a PT_GNU_ATTR segment
> 	if there is an attribute section.
> 	(_bfd_elf_map_sections_to_segments): Likewise.
> 	(IS_SECTION_IN_INPUT_SEGMENT): Likewise.
> 
> binutils/
> 2007-08-15  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* readelf.c (get_segment_type): Change PT_GNU_STACK to
> 	PT_GNU_ATTR.
> 
> include/elf/
> 2007-08-15  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* common.h (PT_GNU_STACK): Renamed to ...
> 	(PT_GNU_ATTR): This.
> 	(PT_GNU_STACK): New.  Make an alias of PT_GNU_ATTR.

Approved - please apply.

Cheers
   Nick



More information about the Binutils mailing list