better error messages

Nick Clifton nickc@redhat.com
Mon Aug 6 15:55:00 GMT 2007


Hi Nathan,

> This patch adds a new bfd_nonfatal_message function, which produces more 
> informative messages naming the bfd and the section, where applicable.  

I agree with Andreas's comment that the new function needs to have a comment 
header describing its inputs.  In addition why did you remove the 
RETURN_NONFATAL macro ?  It would be cleaner to leave in place and just change 
its argument to be the bfd.

 > in
 > preference to bfd_nonfatal (which should be deprecated, IMHO).

I don't agree.  I think that there is a place for the bfd_nonfatal function, 
for situations where a bfd is not available or not applicable.

Cheers
   Nick



More information about the Binutils mailing list