Fallout for VAX (was: --enable-checking for gas)

[Jan-Benedict Glaw]

On Sat, 2007-04-21 14:46:32 +0930, Alan Modra <amodra@bigpond.net.au> wrote:
> gas/
> 	* as.h (ENABLE_CHECKING): Default define to 0.
> 	(know): Assert if ENABLE_CHECKING.
> 	(struct relax_type): Remove superfluous declaration.
> 	* configure.in (--enable-checking): New.
> 	* configure: Regenerate.
> 	* config.in: Regenerate.
> 	* config/tc-ppc.c (ppc_setup_opcodes): Do checks when ENABLE_CHECKING.
> 	Check for duplicate powerpc_operands entries.

Now where know() really does do its work for CVS builds, we see some
fallout for eg. vax-linux-uclibc:

gcc -DHAVE_CONFIG_H -I. -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas -I. -D_GNU_SOURCE -I. -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas -I../bfd -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/config -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/../include -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/.. -I/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/../bfd -DLOCALEDIR="\"/tmp/build-temp-vax-linux-uclibc/install/usr/share/locale\""   -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror -g -O2 -c /tmp/build-temp-vax-linux-uclibc/src/binutils/gas/config/atof-vax.c
cc1: warnings being treated as errors
/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/config/atof-vax.c: In function #md_atof#:
/tmp/build-temp-vax-linux-uclibc/src/binutils/gas/config/atof-vax.c:438: warning: comparison between signed and unsigned
make[3]: *** [atof-vax.o] Error 1
make[3]: Leaving directory `/tmp/build-temp-vax-linux-uclibc/build/binutils/gas'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/build-temp-vax-linux-uclibc/build/binutils/gas'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/tmp/build-temp-vax-linux-uclibc/build/binutils/gas'
make: *** [all-gas] Error 2

If Matt doesn't object, I'd like to install this patch to fix it:

2007-04-21	Jan-Benedict Glaw <jbglaw@lug-owl.de>

gas/
	* config/atof-vax.c: Update copyright year.
	(atof_vax_sizeof): Return unsigned int instead of int.
	(md_atof): Make number_of_chars unsigned int, too.
	(MAXIMUM_NUMBER_OF_LITTLENUMS): Remove single space.

--- src-binutils-fresh/gas/config/atof-vax.c	2005-05-05 11:12:52.000000000 +0200
+++ src-binutils-hacked/gas/config/atof-vax.c	2007-04-21 14:34:51.000000000 +0200
@@ -1,5 +1,5 @@
 /* atof_vax.c - turn a Flonum into a VAX floating point number
-   Copyright 1987, 1992, 1993, 1995, 1997, 1999, 2000, 2005
+   Copyright 1987, 1992, 1993, 1995, 1997, 1999, 2000, 2005, 2007
    Free Software Foundation, Inc.
 
    This file is part of GAS, the GNU Assembler.
@@ -35,7 +35,7 @@ int flonum_gen2vax (int, FLONUM_TYPE *, 
 
 /* Number of chars in flonum type 'letter'.  */
 
-static int
+static unsigned int
 atof_vax_sizeof (int letter)
 {
   int return_value;
@@ -386,7 +386,7 @@ flonum_gen2vax (int format_letter,	/* On
   	Floating point literal.
   	Number of chars we used for the literal.  */
 
-#define MAXIMUM_NUMBER_OF_LITTLENUMS  8 	/* For .hfloats.  */
+#define MAXIMUM_NUMBER_OF_LITTLENUMS  8		/* For .hfloats.  */
 
 char *
 md_atof (int what_statement_type,
@@ -395,7 +395,7 @@ md_atof (int what_statement_type,
 {
   LITTLENUM_TYPE words[MAXIMUM_NUMBER_OF_LITTLENUMS];
   char kind_of_float;
-  int number_of_chars;
+  unsigned int number_of_chars;
   LITTLENUM_TYPE *littlenumP;
 
   switch (what_statement_type)


MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of: 23:53 <@jbglaw> So, ich kletter' jetzt mal ins Bett.
the second  : 23:57 <@jever2> .oO( kletter ..., hat er noch Gitter vorm Bett, wie früher meine Kinder?)
              00:00 <@jbglaw> jever2: *patsch*
              00:01 <@jever2> *aua*, wofür, Gedanken sind frei!
              00:02 <@jbglaw> Nee, freie Gedanken, die sind seit 1984 doch aus!
              00:03 <@jever2> 1984? ich bin erst seit 1985 verheiratet!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <https://sourceware.org/pipermail/binutils/attachments/20070421/34c733f5/attachment.sig>