PATCH: PR ld/4304: ld --fatal-warnings doesn't work

[Nick Clifton]

Hi H. J.

> This is the patch I am checking in. The old linker gives
> 
> bash-3.1$ make LD=ld
> gcc -c -m32 -o 32.o foo.c
> ld -shared -melf_i386 --warn-shared-textrel --fatal-warnings -o 32.so
> 32.o
> ld: warning: creating a DT_TEXTREL in a shared object.
> bash-3.1$ 
> 
> The new linker gives
> 
> bash-3.1$ make
> gcc -c -m32 -o 32.o foo.c
> ./ld -shared -melf_i386 --warn-shared-textrel --fatal-warnings -o 32.so
> 32.o
> ./ld: warning: creating a DT_TEXTREL in a shared object.
> make: *** [32.so] Error 1

This does not seem quite right to me.  If this warning is sufficiently 
serious that it is going to prevent the generation of a working 
executable then why is it only a warning and not an error ?

Cheers
   Nick