[PATCH] Make the compiler do the math.

Nick Clifton nickc@redhat.com
Fri Sep 15 09:46:00 GMT 2006


Hi Pedro,

> It seems I can't do anything right the first time. (Sigh...)

:-)

>     * pe-dll.c (AFET): New macro.

The name "AFET" is a little bit obscure.  I would have thought a more 
self-documenting name would be better, eg AUTOFILTER_ENTRY or 
STRING_AND_LEN.

Also I think that it would be a great idea if this macro were placed in 
a header file (eg bfd.h via bfd-in.h) so that it could be used elsewhere 
in the binutils code (eg bfd/elf.c, bfd/archive.c, binutils/readelf.c). 
  In this case I think that a more generic name for the macro would be 
appropriate (eg STRING_COMMA_LEN).

Cheers
   Nick




More information about the Binutils mailing list